Replaced clock_schem.pdf with more correct

+ Added 600ms pause before spin numbers if button pressed
* Changed increment delay 500ms -> 200ms
* Button bounce compensation code

.hgignore

@@ -0,0 +1,6 @@
+^\.vscode
+\.swp$
+\.bak$
+\.old$
+\.orig$
+\.clang-format

.hgtags

@@ -1 +1,2 @@
 ee4999ebdd2d1b54512facafdd03c8a530ea4bfa v1.0
+1167bd4b622768ed17e116a4cbac3db90031e6f8 v1.1

README.md

@@ -4,13 +4,23 @@
 
 ### Component base is very simple:
 
-* Arduino NANO v3 chinese replica
+* Arduino NANO v3 chinese replica (on Atmega-168 chip)
-* 7 segment 4 digit LED indicator with common anode, FYQ-5641BG-21
+* 7 segment 4 digit LED indicator with common anode, FYQ-5641BD-21 (red LEDs)
 * 8 resistors that limiting current on LED segments, 330 Ohms, 0.25 watts
-* RTC Module GEEGROW with DS1307 chip
+* RTC Module GEEGROW with DS1307 chip (very basic, only RTC chip, quartz resonator, button battery, no additional memory chip)
 * 5x7 cm single side prototyping board
 * usb phone charger as power supply
 * 2 push buttons
 * 1 on/off switch
 * Gainta G521G enclosure (92x66.5x28мм)
 * 5m power cord
+
+### Optionally you may need:
+
+* Capasitor with well capacity if your charger has small capasitor on output
+* Fuse, to protect your device
+* DC/DC transformer if you have power supply that gives more than 5 volts or less than 4.5 volts (this will give additional surge protection if your power supply dies, this can happen after 3-5 years of uninterrupted work)
+
+### Additional Notes:
+
+My RTC module is not very accurate due to bad quartz chrystal calibration, looks like it is not exactly 32768 Hz and clock runs faster than it should be, giving about 5-8 seconds runaway per day. So i have to implement time correction in software (temperature changes during day/month/year is not very big - about 10 degrees Celsius, so we can use software compensation without thermal compensation).

simpleclock.ino

@@ -1,53 +1,66 @@
 /*
  * 7 Segment 4 Digits clock with digit point separator
  *
- *           It uses display module with common anode and DS1307
+ * It uses display module with common anode and DS1307 RTC module to enhance
- *           RTC module to enhance time keeping ability of
+ * time keeping ability of Atmega 328p based Arduino Nano microcontroller and
- *           Atmega 328p based Arduino nano microcontroller and
  * 2 buttons for adjusting time.
  */
 
 /* This software distributed under BSD 2 Clause License
-
+ *
-Copyright (c) Sergei Fedosoff, All rights reserved.
+ * Copyright (c) Sergei Fedosoff, All rights reserved.
-
+ *
-Redistribution and use in source and binary forms, with or without modification,
+ * Redistribution and use in source and binary forms, with or without
-are permitted provided that the following conditions are met:
+ * modification, are permitted provided that the following conditions
-
+ * are met:
-Redistributions of source code must retain the above copyright notice, this list
+ *
-of conditions and the following disclaimer. Redistributions in binary form must
+ * Redistributions of source code must retain the above copyright
-reproduce the above copyright notice, this list of conditions and the following
+ * notice, this listof conditions and the following disclaimer.
-disclaimer in the documentation and/or other materials provided with the
+ * Redistributions in binary form must reproduce the above copyright
-distribution. THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND
+ * notice, this list of conditions and the following disclaimer in the
-CONTRIBUTORS "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+ * documentation and/or other materials provided with the distribution.
-LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A
+ *
-PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR
+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
-CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY,
+ * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
-OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
+ * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
-SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
+ * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
-INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
+ * HOLDER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
-CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING
+ * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED
-IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY
+ * TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
-OF SUCH DAMAGE.
+ * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF
+ * LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING
+ * NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
+ * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITYOF SUCH DAMAGE.
  */
 
-#include <SevSeg.h>
+/* DS1307 lib by FrankieChu for Seeed RTC module, in my case
-#include <Wire.h>
+ * Grove___RTC_DS1307-1.0.0.zip */
-#include <TimeLib.h>
-// DS1307 lib by FrankieChu for Seeed RTC module
 #include <DS1307.h>
+#include <SevSeg.h>
 
 DS1307 clock;
 SevSeg Display;
 
+/* push button stuff */
+const long initial_delay = 600;   // wait a bit before spin numbers
+const long adjust_interval = 200; // delay between consecutive number increnents
+const long bounce_delay = 20;     // contact bounce compensation
+const int hrs_btn = A0;           // put hour adjusting button on A0 lane
+const int min_btn = A1;           // put minute adjusting button on A1 lane
+bool btn_pushed = false;          // is button pushed?
+unsigned long currentPushTimer;
+unsigned long previousPushTimer = 0;
+uint8_t minutes;
+uint8_t hours;
+
+/* dot blinking stuff */
 unsigned long currentMillis;
 unsigned long previousMillis = 0;
 const long interval = 500;
-const int hrs_btn = A0;
-const int min_btn = A1;
 bool dot = true;
-uint8_t minutes;
+
-uint8_t hours;
+/* time inaccuracy compensation flag */
+uint8_t compflag = 0;
 
 void setup()
 {
@@ -58,13 +71,14 @@ void setup()
 	byte segmentPins[] = {2, 3, 4, 5, 6, 7, 8, 13};
 	bool resistorsOnSegments = true; // 8 resistors, 330 Ohms each
 	bool updateWithDelays = false;   // Default. Recommended
-	/* without it there is visual bug at 0 o'clock, and in current version of
+
-	 * SevSeg' setChars() does not dots at all */
+	/* without it there is visual bug at 0 o'clock, and in current version
+	 * of SevSeg' setChars() does not dots at all */
 	bool leadingZeros = false;
 
 	Display.begin(hardwareConfig, numDigits, digitPins, segmentPins,
                       resistorsOnSegments, updateWithDelays, leadingZeros);
-	Display.setBrightness(90);
+	Display.setBrightness(100);
 
 	// setup clock
 	clock.begin();
@@ -72,10 +86,9 @@ void setup()
 	// if rtc returns incorrect time, reset it to some default value
 	clock.getTime();
 
-	if (( clock.hour > 23 ) || (clock.minute > 59))
+	if ((clock.hour > 23) || (clock.minute > 59)) {
-	{
+		clock.fillByYMD(2019, 2, 23); // 23 Feb 2019
-		clock.fillByYMD(2019,2,23);  // 23 Feb 2013
+		clock.fillByHMS(15, 52, 30);  // 15:52:30"
-		clock.fillByHMS(15,52,30);   // 15:52 30"
 		clock.fillDayOfWeek(SAT);     // Saturday
 		clock.setTime();              // put date to rtc
 	}
@@ -85,70 +98,94 @@ void setup()
 	pinMode(min_btn, INPUT_PULLUP);
 }
 
-
 void loop()
 {
-	unsigned long currentMillis = millis();
+	currentMillis = millis();
+	currentPushTimer = currentMillis;
 	char str[4];
 	float d;
 
-	if (currentMillis - previousMillis >= interval)
-	{
-		previousMillis = currentMillis;
-
-		if (dot == false)
-		{
-			dot = true;
-
-			if (digitalRead(hrs_btn) == LOW)
-			{
 	clock.getTime();
+
+	// push button magic
+	if ((!btn_pushed) and
+            ((digitalRead(hrs_btn) == LOW) or (digitalRead(min_btn) == LOW))) {
+		if (currentPushTimer - previousPushTimer >= initial_delay) {
+			previousPushTimer = currentPushTimer;
+			btn_pushed = true;
+		}
+	}
+
+	if (btn_pushed and
+            (digitalRead(hrs_btn) != LOW) and (digitalRead(min_btn) != LOW)) {
+		// compensate possible contact bounce with delay
+		if (currentPushTimer - previousPushTimer >= bounce_delay) {
+			btn_pushed = false;
+		}
+	}
+
+	if (btn_pushed) {
+		if (currentPushTimer - previousPushTimer >= adjust_interval) {
+			previousPushTimer = currentPushTimer;
+
+			if (digitalRead(hrs_btn) == LOW) {
 				hours = clock.hour + 1;
 				(hours > 23) ? hours = 0 : hours;
 				clock.fillByHMS(hours, clock.minute, 0);
 				clock.setTime();
 			}
 
-			if (digitalRead(min_btn) == LOW)
+			if (digitalRead(min_btn) == LOW) {
-			{
-				clock.getTime();
 				minutes = clock.minute + 1;
 				(minutes > 59) ? minutes = 0 : minutes;
 				clock.fillByHMS(clock.hour, minutes, 0);
 				clock.setTime();
 			}
 		}
-		else
-		{
-			dot = false;
-		}
 	}
 
-	clock.getTime();
+	if (currentMillis - previousMillis >= interval) {
+		previousMillis = currentMillis;
+
+		if (dot)
+			dot = false;
+		else
+			dot = true;
+	}
+
+	/*
+	 * Let's implement time compenstion for individual rtc module time
+	 * charachteristics. In in my case quartz resonator as inaccurate as
+	 * +/- about 5-8 seconds per 24 hours, maybe its require more EMI
+	 * shielding?
+	 */
+
+	if ((clock.hour == 21) and (clock.minute == 21) and
+            (clock.second == 21) and (compflag == 0)) {
+		clock.fillByHMS(clock.hour, clock.minute, 14);
+		clock.setTime();
+		compflag = 1;
+	}
+
+	if ((clock.hour == 21) and (clock.minute == 21) and
+            (clock.second == 23) and (compflag == 1)) {
+		compflag = 0;
+	}
 
 	// make blinking dot
-	if (clock.hour > 0)
+	if (clock.hour > 0) {
-	{
+		if (dot) {
-		if (dot == true) 
-		{
 			Display.setNumber((clock.hour * 100 + clock.minute), 2);
-		}
+		} else {
-		else
-		{
 			Display.setNumber((clock.hour * 100 + clock.minute));
 		}
-	}
+	} else {
-	else
+		/* 0 o'clock is an exception, we don't want to see "00.00", we
-	{
+		   want see "0.00" or "0 00", so we have to use this "hack" */
-		/* 0 o'clock is an exception, we dont want to see "00.00", we want see
+		if (dot) {
-		 * "0.00" or "0 00", so we have to use this "hack" */
-		if (dot == true)
-		{
 			d = float(clock.minute) / 100;
 			Display.setNumber(d, 2);
-		}
+		} else {
-		else
-		{
 			sprintf(str, "%2d%02d", clock.hour, clock.minute);
 			Display.setChars(str);
 		}