From a475f9df24d99b76f1a601da3239bff91223bc6f Mon Sep 17 00:00:00 2001
From: eleksir <none@none>
Date: Sun, 4 Sep 2016 22:42:31 +0300
Subject: [PATCH] cleanup ads_register_dns.sh

---
 ads_register_dns.sh | 16 ++++++++++------
 1 file changed, 10 insertions(+), 6 deletions(-)

diff --git a/ads_register_dns.sh b/ads_register_dns.sh
index e0c3810..3964250 100755
--- a/ads_register_dns.sh
+++ b/ads_register_dns.sh
@@ -4,20 +4,24 @@ NET="/usr/local/samba/bin/net"
 
 quiet="$1"
 ads_register_dns() {
-	_ads=`${GETCFG} global security -d USER -f /etc/config/smb.conf`
-	if [ "x${_ads}" = "xADS" ]; then
-		_reg_dns=`${GETCFG} Samba "register dns" -d FALSE`
-		if [ "x${_reg_dns}" = "xTRUE" ]; then
+	_ads="$(${GETCFG} global security -d USER -f /etc/config/smb.conf)"
+
+	if [ "${_ads}" == "ADS" ]; then
+		_reg_dns="$(${GETCFG} Samba "register dns" -d FALSE)"
+
+		if [ "${_reg_dns}" == "TRUE" ]; then
 			try=0
+
 			while [ $try -lt 3 ]; do
-				${NET} ads dns register -P
-				if [ $? = 0 ]; then
+				"${NET}" ads dns register -P
+				if [ $? == 0 ]; then
 					[ "$quiet" == "" ] && /sbin/write_log "[Microsoft Networking] The NAS has been registered successfully in DNS" 4
 					break
 				fi
 				/bin/sleep 1
 				let "try++"
 			done
+
 			if [ $try -ge 3 ]; then
 				/sbin/write_log "[Microsoft Networking] The NAS registration in DNS failed" 2
 			fi