From 4beda1639e15a4652d964fc87154a987b58fb5ce Mon Sep 17 00:00:00 2001 From: eleksir Date: Tue, 31 Mar 2026 00:59:34 +0300 Subject: [PATCH] Fix hypotetical file leakage in cputemp.go --- internal/lib/cputemp.go | 55 ++++++++++++++++++----------------------- 1 file changed, 24 insertions(+), 31 deletions(-) diff --git a/internal/lib/cputemp.go b/internal/lib/cputemp.go index 37847a7..e37087c 100644 --- a/internal/lib/cputemp.go +++ b/internal/lib/cputemp.go @@ -36,38 +36,31 @@ func (c *MyConfig) UpdateCPUTemperature() { if err != nil { log.Printf("Unable to open %s: %s", filename, err) - } else { - reader := bufio.NewReader(file) - line, _, err := reader.ReadLine() - - if err != nil { - log.Printf("Unable to read from %s: %s", filename, err) - err = file.Close() - - if err != nil { - log.Printf("Unable to close %s: %s", filename, err) - } - } else { - err = file.Close() - - if err != nil { - log.Printf("Unable to close %s: %s", filename, err) - } else { - temp, err := strconv.ParseInt(string(line), 10, 32) - - if err != nil { - log.Printf("Unable to convert string to number from file %s: %s", filename, err) - } else { - if temp > 1000 { - temp /= 1000 - } - - temperature[i] = temp - validCount++ - } - } - } + continue } + defer file.Close() + + reader := bufio.NewReader(file) + line, _, err := reader.ReadLine() + + if err != nil { + log.Printf("Unable to read from %s: %s", filename, err) + continue + } + + temp, err := strconv.ParseInt(string(line), 10, 32) + + if err != nil { + log.Printf("Unable to convert string to number from file %s: %s", filename, err) + continue + } + + if temp > 1000 { + temp /= 1000 + } + + temperature[i] = temp + validCount++ } if validCount == 0 {