eleksir/aleesa-jabber-bot
1
Fork 0
Code Activity

More heavy perlcritic policies, more careful work with strings/substr

Browse Source
This commit is contained in:
eleksir
2022-04-03 13:45:02 +03:00
parent 5e53450221
commit f18544a798
22 changed files with 271 additions and 227 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
lib/BotLib/Fortune.pm
View File

@@ -11,7 +11,6 @@ use Carp qw (croak);
use File::Path qw (make_path);
use Log::Any qw ($log);
use Math::Random::Secure qw (irand);
use MIME::Base64;
use SQLite_File;
use BotLib::Conf qw (LoadConf);
@@ -30,7 +29,7 @@ sub Seed () {
my $backingfile = sprintf '%s/fortune.sqlite', $dir;
if (-f $backingfile) {
if (-e $backingfile) {
unlink $backingfile || croak "Unable to remove $backingfile: $OS_ERROR\n";
}
@@ -40,7 +39,7 @@ sub Seed () {
while (my $fortunefile = readdir $srcdirhandle) {
my $srcfile = sprintf '%s/%s', $srcdir, $fortunefile;
unless (-f $srcfile) {
unless (-e $srcfile) {
next;
}
@@ -53,7 +52,7 @@ sub Seed () {
local $INPUT_RECORD_SEPARATOR = "\n%\n";
while (readline $fh) {
my $phrase = substr $_, 0, -3;
my $phrase = substr $_, 0, length ("\n%\n");
push @fortune, $phrase;
}