eleksir/aleesa-jabber-bot
1
Fork 0
Code Activity

Use check for defined value after eval(), style fixes, fix typo in sub name and var name

Browse Source
This commit is contained in:
eleksir
2021-03-29 00:19:51 +03:00
parent a406c7c717
commit eb12b23a3d
11 changed files with 38 additions and 36 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
lib/BotLib/Drink.pm
View File

@@ -43,27 +43,27 @@ sub Drink {
if ($r->{success}) {
# TODO: Handle unexpected content
my $p = HTML::TokeParser->new(\$r->{content});
my $p = HTML::TokeParser->new (\$r->{content});
my @a;
my @holyday;
my @holiday;
do {
$#a = -1;
@a = $p->get_tag('span'); ## no critic (Variables::RequireLocalizedPunctuationVars)
@a = $p->get_tag ('span'); ## no critic (Variables::RequireLocalizedPunctuationVars)
if ($#{$a[0]} > 2 && defined $a[0][1]->{itemprop} && $a[0][1]->{itemprop} eq 'text') {
push @holyday,'* ' . decode ('UTF-8', $p->get_trimmed_text ('/span'));
push @holiday,'* ' . decode ('UTF-8', $p->get_trimmed_text ('/span'));
}
} while ($#{$a[0]} > 1);
if ($#holyday > 0) {
if ($#holiday > 0) {
# cut off something weird, definely not a "holyday"
$#holyday = $#holyday - 1;
$#holiday = $#holiday - 1;
}
if ($#holyday > 0) {
$ret = join "\n", @holyday;
if ($#holiday > 0) {
$ret = join "\n", @holiday;
}
} else {
cluck sprintf 'Server return status %s with message: %s', $r->{status}, $r->{reason};