aleesa-bot/aleesa-telegram
0
Fork 0
Code Pull Requests Projects Releases Activity

Apply perlcritic

Browse Source
This commit is contained in:
eleksir
2021-07-03 11:20:13 +03:00
parent eddbcc6277
commit cf71cd7f6f
1 changed files with 28 additions and 29 deletions
Download Patch File Download Diff File Expand all files Collapse all files

57
lib/BotLib/Gamestat.pm
View File

@@ -26,7 +26,7 @@ my $dbfile = sprintf '%s/gamestat.sqlite', $gamestatdir;
# assume that there is not too much artifacts. # assume that there is not too much artifacts.
sub SeedArtifacts { sub SeedArtifacts {
open (my $AFH, '<', "$dir/archeologic_artifacts.txt") || die "No $dir/archeologic_artifacts.txt"; open (my $AFH, '<', "$dir/archeologic_artifacts.txt") || die "No $dir/archeologic_artifacts.txt\n";
my @arch_artifacts; my @arch_artifacts;
while (my $artifact = <$AFH>) { while (my $artifact = <$AFH>) {
@@ -35,9 +35,9 @@ sub SeedArtifacts {
push @arch_artifacts, $artifact; push @arch_artifacts, $artifact;
} }
close $AFH; close $AFH; ## no critic (InputOutput::RequireCheckedSyscalls)
open ($AFH, '<', "$dir/fisher_artifacts.txt") || die "No $dir/fisher_artifacts.txt"; open ($AFH, '<', "$dir/fisher_artifacts.txt") || die "No $dir/fisher_artifacts.txt\n";
my @fisher_artifacts; my @fisher_artifacts;
while (my $artifact = <$AFH>) { while (my $artifact = <$AFH>) {
@@ -46,10 +46,10 @@ sub SeedArtifacts {
push @fisher_artifacts, $artifact; push @fisher_artifacts, $artifact;
} }
close $AFH; close $AFH; ## no critic (InputOutput::RequireCheckedSyscalls)
undef $AFH; undef $AFH;
my $tablename = random_string (".........."); my $tablename = random_string ('..........');
$tablename = utf2sha1 ($tablename); $tablename = utf2sha1 ($tablename);
while ($tablename =~ /^\d/) { while ($tablename =~ /^\d/) {
@@ -60,56 +60,55 @@ sub SeedArtifacts {
$tablename = lc ($tablename); $tablename = lc ($tablename);
unless (-d $gamestatdir) { unless (-d $gamestatdir) {
make_path ($gamestatdir) || die "Unable to create $dir: $OS_ERROR"; make_path ($gamestatdir) || die "Unable to create $dir: $OS_ERROR\n";
} }
my $dbh = DBI->connect ("dbi:SQLite:$dbfile", '', ''); my $dbh = DBI->connect ("dbi:SQLite:$dbfile", '', '');
$dbh->{sqlite_unicode} = 1; $dbh->{sqlite_unicode} = 1;
my $rows_affected = $dbh->do ('PRAGMA foreign_keys=ON') or die $dbh->errstr; my $rows_affected = $dbh->do ('PRAGMA foreign_keys=ON') or die $dbh->errstr . "\n";
$rows_affected = $dbh->do ('PRAGMA journal_mode=WAL') or die $dbh->errstr; $rows_affected = $dbh->do ('PRAGMA journal_mode=WAL') or die $dbh->errstr . "\n";
# Open transaction # Open transaction
$dbh->begin_work or die $dbh->errstr; $dbh->begin_work or die $dbh->errstr . "\n";
$rows_affected = $dbh->do ( my $query = <<"QUERY";
qq { CREATE TABLE IF NOT EXISTS $tablename (
CREATE TABLE IF NOT EXISTS $tablename ( id INT UNIQUE NOT NULL, -- artifact id
id INT UNIQUE NOT NULL, -- artifact id name TEXT PRIMARY KEY -- artifact name
name TEXT PRIMARY KEY -- artifact name );
); QUERY
}
) or die $dbh->errstr;
my $sth = $dbh->prepare ("REPLACE INTO $tablename(id,name) VALUES (?,?)") or die $dbh->errstr; $rows_affected = $dbh->do ($query) or die $dbh->errstr . "\n";
my $sth = $dbh->prepare ("REPLACE INTO $tablename(id,name) VALUES (?,?)") or die $dbh->errstr . "\n";
# Insert our archeological artifacts # Insert our archeological artifacts
my $c = 0; my $counter = 0;
foreach my $artifact (@arch_artifacts) { foreach my $artifact (@arch_artifacts) {
last if ($c == 10000); last if ($counter == 10000);
$sth->execute ($c, $artifact); $sth->execute ($c, $artifact);
$c++; $counter++;
} }
# Insert our fishing artifacts # Insert our fishing artifacts
$c = 10000; $counter = 10000;
foreach my $artifact (@fisher_artifacts) { foreach my $artifact (@fisher_artifacts) {
last if ($c == 20000); last if ($counter == 20000);
$sth->execute ($c, $artifact); $sth->execute ($c, $artifact);
$c++; $counter++;
} }
# Add indexes # Add indexes
$rows_affected = $dbh->do ("CREATE INDEX IF NOT EXISTS myartifactid ON $tablename(id)") or die $dbh->errstr; $rows_affected = $dbh->do ("CREATE INDEX IF NOT EXISTS myartifactid ON $tablename(id)") or die $dbh->errstr . "\n";
# Drop target table and replace it with our # Drop target table and replace it with our
$rows_affected = $dbh->do ("DROP TABLE IF EXISTS artifacts") or die $dbh->errstr; $rows_affected = $dbh->do ('DROP TABLE IF EXISTS artifacts') or die $dbh->errstr . "\n";
$rows_affected = $dbh->do ("ALTER TABLE $tablename RENAME TO artifacts") or die $dbh->errstr; $rows_affected = $dbh->do ("ALTER TABLE $tablename RENAME TO artifacts") or die $dbh->errstr . "\n";
# Close transaction # Close transaction
$dbh->commit or die $dbh->errstr; $dbh->commit or die $dbh->errstr . "\n";
$dbh->disconnect or warn (sprintf '[WARN] Unable to close gamestat db, sqlite error: %s', $dbh->errstr); $dbh->disconnect or warn (sprintf '[WARN] Unable to close gamestat db, sqlite error: %s', $dbh->errstr) . "\n";
return; return;
} }