aleesa-bot/aleesa-telegram
0
Fork 0
Code Pull Requests Projects Releases Activity

Lint Teapot::Bot with perlcritic

Browse Source 
* Use List::Util' any instead of grep in Base.pm
* Use croak() in Base.pm
This commit is contained in:
eleksir
2020-10-31 13:20:27 +03:00
parent a480786afa
commit 97eddd414d
35 changed files with 227 additions and 164 deletions
Download Patch File Download Diff File Expand all files Collapse all files

40
.perlcriticrc
View File

@@ -4,38 +4,38 @@ verbose = 8
# minorify some of warnings that are not really critical
[-InputOutput::RequireCheckedClose]
# what can we handle in case of error?
# What can we handle in case of error?
[-Modules::ProhibitExcessMainComplexity]
# noone cares
# Noone cares
[-Subroutines::ProhibitExcessComplexity]
# noone cares
# Noone cares
[-Subroutines::ProhibitExplicitReturnUndef]
# but it's very handy sometimes!
# But it's very handy sometimes!
[-ValuesAndExpressions::ProhibitMagicNumbers]
# this policy makes too much false positives
[-RegularExpressions::RequireLineBoundaryMatching]
# we use /m as needed
# We use /m as needed
[-RegularExpressions::RequireExtendedFormatting]
# we do not use extended formatting of regex, they still not THAT complex
# We do not use extended formatting of regex, they still not THAT complex
[-RegularExpressions::RequireDotMatchAnything]
# huh?
[-RegularExpressions::ProhibitEscapedMetacharacters]
# looks like it pointless
# Looks like it pointless
[-ControlStructures::ProhibitCascadingIfElse]
# I like long ifelse chains
# I like long if..else chains
[-ControlStructures::ProhibitPostfixControls]
# in short lines we can afford ourselves to use postfix controls
# but ofcorse we shoul avoid such constructions in long lines
# In short lines we can afford ourselves to use postfix controls
# but ofcorse we should avoid such constructions in long lines.
[-Subroutines::ProhibitSubroutinePrototypes]
# Contrary to Perl::Critic we consider prototypes as useful, even if
@@ -43,9 +43,9 @@ verbose = 8
# hints.
[-CodeLayout::RequireTidyCode]
# impossible to complete, because of on higher linting levels ## no critic
# Impossible to complete, because of on higher linting levels "## no critic..."
# require be per-case on same line where critique is, but tidy align them
# one line down
# one line down.
[-CodeLayout::ProhibitParensWithBuiltins]
# duh...
@@ -55,7 +55,7 @@ verbose = 8
# the recomended use of q{} looks too complex: my $var = q{};
[-ValuesAndExpressions::ProhibitNoisyQuotes]
# other people, other opinions: "," is better readable than qw(,)
# Other people, other opinions: "," is better readable than qw(,)
[-BuiltinFunctions::ProhibitSleepViaSelect]
# We do not wish to use too much external modules.
@@ -67,14 +67,22 @@ verbose = 8
# Noone care, really
[-ControlStructures::ProhibitUnlessBlocks]
# they should not be too complex - only one condition should be checked,
# They should not be too complex - only one condition should be checked,
# that's all
[-Miscellanea::ProhibitTies]
# Just allow it. It's very handy stuff and extremely simple and safe enugh to use.
[-ValuesAndExpressions::RequireNumberSeparators]
# not really
# Not really
[-InputOutput::RequireBracedFileHandleWithPrint]
# we prefer not to use braced file handles
# We prefer not to use braced file handles
[-Documentation::PodSpelling]
# It doesn't help, but emits annoying errors
[Documentation::RequirePodSections]
# Considering this as "soft" requirement. For modules that is (or will be)
# stand-alone libs well formed documentation is highly desired.
lib_sections = NAME | VERSION | DESCRIPTION | AUTHOR | LICENSE AND COPYRIGHT